Pin lightning-liquidity and cut v0.4.3 patch release#439
Merged
tnull merged 2 commits intolightningdevkit:release/0.4from Jan 23, 2025
Merged
Pin lightning-liquidity and cut v0.4.3 patch release#439tnull merged 2 commits intolightningdevkit:release/0.4from
lightning-liquidity and cut v0.4.3 patch release#439tnull merged 2 commits intolightningdevkit:release/0.4from
Conversation
In the meantime `lightning-liquidity` v0.1.0 was released, which will have builds of LDK Node v0.4.2 fail as `cargo` by default treats it as compatible (even though it's not) and tries to upgrade to the latest version. While users could pin the crate version back themselves, we here pin it for the time being to fix the v0.4.x builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the time since the LDK Node v0.4.2 release,
lightning-liquidityv0.1.0 was released, which will have builds of LDK Node v0.4.2 fail ascargoby default treats it as API-compatible (even though it's not) and tries to upgrade to the latest version. While users could pin the crate version back themselves, we here pin it for the time being to fix the v0.4.x builds.We then cut the v0.4.3 only containing this trivial change.